Close addressed comments on PRs, and add teaching bot#48
Merged
illicitonion merged 4 commits intomainfrom Dec 19, 2025
Merged
Conversation
And start inferring converted slice lengths, which is from a newer rust than we were building on CI.
This makes the PRs less noisy and easier to skim. This just closes all PR Metadata Validator comments on a clean run. We could be more precise if we wanted to be, e.g. closing unrelated issues if new ones are detected.
This allows us to use the same infrastructure we use for PR metadata validation, but in a more controlled setting for learning what a bot comment is. The comment it leaves is fairly artificial, but should be easy for people to understand and act on.
cifarquhar
approved these changes
Dec 19, 2025
cifarquhar
left a comment
cifarquhar
left a comment
There was a problem hiding this comment.
Looks good! I'll incorporate the dummy validator into the Github workshop in onboarding week once this is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Individual commits are standalone reviewable:
Close addressed comments on PRs
This makes the PRs less noisy and easier to skim.
This just closes all PR Metadata Validator comments on a clean run. We
could be more precise if we wanted to be, e.g. closing unrelated issues
if new ones are detected.
Add binary for simplified bot comment training
This allows us to use the same infrastructure we use for PR metadata
validation, but in a more controlled setting for learning what a bot
comment is.
The comment it leaves is fairly artificial, but should be easy for
people to understand and act on.